Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail: improve temp file selection #316

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 6, 2023

  • Use logic in File::Temp to avoid name collision for temporary file
  • I tested this by loading a mailbox, selecting message 2 then "viewing" it...

perl mail # reads $HOME/mbox by default
2
v
...quit vi
q

  • We don't need to set file with $tmbox->file(...) because new() already set it
  • While here, remove useless debug message about entering "stuff" function

* Use logic in File::Temp to avoid name collision for temporary file
* I tested this by loading a mailbox, selecting message 2 then "viewing" it...

perl mail # reads $HOME/mbox by default
2
v
...quit vi
q

* We don't need to set file with $tmbox->file(...) because new() already set it
* While here, remove useless debug message about entering "stuff" function
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mail The mail program labels Nov 6, 2023
@briandfoy briandfoy merged commit 2c943ee into briandfoy:master Nov 9, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 9, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: mail The mail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants