Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: target path in install_files() #339

Merged
merged 1 commit into from
Nov 21, 2023
Merged

install: target path in install_files() #339

merged 1 commit into from
Nov 21, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 21, 2023

  • When destination argument is a directory and source file argument is a relative path in another directory, install gets the wrong destination path...
%perl install build/apply dst 
install: copy build/apply dst/build/apply: No such file or directory
  • The correct destination path is 'dst/apply'
  • Fix this by joining target directory to basename of source file
  • Tested against GNU install

@mknos
install: target path in install_files()
13ca2da 
* When destination argument is a directly and source file argument is in another directory, install gets the wrong destination path

%perl install build/apply dst 
install: copy build/apply dst/build/apply: No such file or directory

* The correct destination path is 'dst/apply'
* Fix this by joining target directory to basename of source file
* Tested against GNU install
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: install The install program labels Nov 21, 2023
@briandfoy briandfoy self-assigned this Nov 21, 2023
@briandfoy briandfoy merged commit ae511f5 into briandfoy:master Nov 21, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: install The install program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy