Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chgrp: '--' option terminator #341

Merged
merged 1 commit into from
Nov 21, 2023
Merged

chgrp: '--' option terminator #341

merged 1 commit into from
Nov 21, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 21, 2023

  • chgrp does not use getopt() but it had code to handle the special argument '--' which indicates the end of options
  • The handling of '--' was incorrect because ARGV list is already shfted into $opt, but the non-option argument after '--' was shifted too
  • With this patch I can do: perl chgrp -- user0 dir1/
  • Found this when testing against GNU chgrp
  • Later, switching chgrp to getopt() could be investigated

@mknos
chgrp: '--' option terminator
29414eb 
* chgrp does not use getopt() but it had code to handle the special argument '--' which indicates the end of options
* The handling of '--' was incorrect because ARGV list is already shfted into $opt, but the non-option argument after '--' was shifted too
* With this patch I can do: perl chgrp -- user0 dir1/
* Found this when testing against GNU chgrp
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: chgrp The chgrp program labels Nov 21, 2023
@briandfoy briandfoy self-assigned this Nov 21, 2023
@briandfoy briandfoy merged commit bf72455 into briandfoy:master Nov 21, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: chgrp The chgrp program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy