Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand: don't slurp input file #344

Merged
merged 2 commits into from
Nov 24, 2023
Merged

expand: don't slurp input file #344

merged 2 commits into from
Nov 24, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 22, 2023

  • Changes are based on a recent commit to unexpand
  • expand_line() replaces do_expand()
  • Remove non-standard -h option; usage string is still printed for -h
  • Update usage string to clarify that spaces are not supported in -tab1,tab2 form
  • POD: Move description of supported tabstop forms into OPTIONS section (providing them is optional)
  • Style: assigning the result of map() is preferred

@mknos
expand: don't slurp input file
3a5025b 
* expand_line() replaces do_expand() --- no dependency exists between lines of output
* Remove -h option; usage string is still printed
* Update usage string to clarify that spaces are not supported in -tab1,tab2 form
* POD: Move description of supported tabstop forms into OPTIONS section (providing them is optional)
* Style: assigning the result of map() is preferred
@mknos
pod typo
3ef47f7
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: expand The expand program labels Nov 22, 2023
@briandfoy briandfoy self-assigned this Nov 24, 2023
@briandfoy briandfoy merged commit 45003a2 into briandfoy:master Nov 24, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: expand The expand program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy