Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexdump: slightly simplify #358

Merged
merged 1 commit into from
Dec 1, 2023
Merged

hexdump: slightly simplify #358

merged 1 commit into from
Dec 1, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 1, 2023

  • Reduce the number of times the flag $opt{'c'} is tested
  • Reduce code nesting by splitting dumper() into two functions (character & hex output)
  • SYNOPSIS did not agree with usage string: file argument is optional
  • Replace "stdin" wording with "standard input" in POD for consistency with other POD manuals
  • Retire EX_USAGE; standard behaviour says exit code above zero is an error so EX_FAILURE is enough

@mknos
hexdump: slightly simplify
12467ef 
* Reduce the number of times the flag $opt{'c'} is tested
* Reduce code nesting by splitting dumper() into two functions (character & hex output)
* SYNOPSIS did not agree with usage string: file argument is optional
* Replace "stdin" wording with "standard input" in POD for consistency with other POD manuals
* Retire EX_USAGE; standard behaviour says exit code above zero is an error so EX_FAILURE is enough
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: hexdump The hexdump program labels Dec 1, 2023
@briandfoy briandfoy self-assigned this Dec 1, 2023
@briandfoy briandfoy merged commit 7df2766 into briandfoy:master Dec 1, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 1, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: hexdump The hexdump program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy