Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: fix decompression feature #365

Merged
merged 1 commit into from
Dec 4, 2023
Merged

grep: fix decompression feature #365

merged 1 commit into from
Dec 4, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 4, 2023

  • By default, this version of grep detects compressed files and decompresses them by running a command via a pipe
  • This feature is not standard for grep, and possibly in future we could add an option to disable it
  • I suspect this was broken by previously converting the script to 3-argument open() --- restore 2-argument open() only for this decompression case
%gzip -k bc
%perl grep sub bc.gz
grep: zcat < bc.gz |: No such file or directory

@mknos
grep: fix decompression feature
f194bd4 
* By default, this version of grep detects compressed files and decompresses them by running a decompress command via a pipe
* This feature is not standard for grep, and possibly in future we could add an option to disable it
* I suspect the feature was broken by previously converting the script to 3-argument open() --- restore 2-argument open() only for this decompression case
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Dec 4, 2023
@briandfoy briandfoy self-assigned this Dec 4, 2023
@briandfoy
Copy link
Owner

I agree that we should remove that feature.

@briandfoy briandfoy merged commit 0f5b938 into briandfoy:master Dec 4, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 4, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy