Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tr: improve -d option #367

Merged
merged 1 commit into from
Dec 5, 2023
Merged

tr: improve -d option #367

merged 1 commit into from
Dec 5, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 5, 2023

  • GNU tr and OpenBSD tr do not allow a 2nd argument with -d, but allow it with -ds
%echo hello | perl tr -d l l # -d is ignored and l is replaced with l
hello
  • Align usage string with SYNOPSIS
  • test1: delete letter l: echo hello | perl tr -d l
  • test2: delete letter l and o: echo hello | perl tr -d lo
  • test3: exchange letters e and o: echo hello | perl tr eo oe
  • Prevent $ARGV[0] from being set to undef by s/// in options loop

@mknos
tr: improve -d option
666fa3b 
* GNU tr and OpenBSD tr do not allow a 2nd argument with -d, but allow it with -ds

%echo hello | perl tr -d l l # -d is ignored and l is replaced with l
hello

* Align usage string with SYNOPSIS
* test1: delete letter l: echo hello | perl tr -d l
* test2: delete letter l and o: echo hello | perl tr -d lo
* test3: exchange letters e and o: echo hello | perl tr eo oe
* Prevent $ARGV[0] from being set to undef by s/// in options loop
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tr The tr program labels Dec 5, 2023
@briandfoy briandfoy self-assigned this Dec 5, 2023
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 5, 2023
@briandfoy briandfoy merged commit 138e3c1 into briandfoy:master Dec 5, 2023
2 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tr The tr program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy