Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply: capture system() failure #376

Merged
merged 1 commit into from
Dec 15, 2023
Merged

apply: capture system() failure #376

merged 1 commit into from
Dec 15, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 14, 2023

  • According with OpenBSD, "apply 1 2 3" should print an error message each time "1" command fails to run, then exit with error code
  • "apply false 2 3" should not print an error message because "false" runs successfully, then exit with error code
  • The return value from system() was not checked previously so no feedback was provided if something went wrong
  • Prefix "usage:" to the usage string
  • Bump version
  • In future it would be useful to add debug option (-d) to show but not run the target commands

@mknos
apply: capture system() failure
724c4ab 
* According with OpenBSD, "apply 1 2 3" should print an error message each time "1" command fails to run, then exit with error code
* "apply false 2 3" should not print an error message because "false" runs successfully, then exit with error code
* The return value from system() was not checked previously so no feedback was provided if something went wrong
* Prefix "usage:" to the usage string
* Bump version
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: apply The apply program labels Dec 14, 2023
briandfoy
briandfoy requested changes Dec 14, 2023
View reviewed changes
bin/apply Show resolved Hide resolved
@briandfoy briandfoy added Status: changes requested adjust the pull request as noted in comments and removed Status: changes requested adjust the pull request as noted in comments labels Dec 14, 2023
@briandfoy briandfoy merged commit 9c0b2c8 into briandfoy:master Dec 15, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 15, 2023
@briandfoy briandfoy self-assigned this Dec 22, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy requested changes

Assignees

@briandfoy briandfoy

Labels
Program: apply The apply program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy