Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

od: fix line offsets #389

Merged
merged 1 commit into from
Dec 27, 2023
Merged

od: fix line offsets #389

merged 1 commit into from
Dec 27, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 26, 2023

  • Byte offsets were broken in a previous commit
  • $offset1 is advanced by -j SKIP_BYTES; otherwise it counts from zero
  • Advance $offset1 only after successfully printing a line of output (this does not affect $is_limit)
  • At EOF, $offset1 is advanced by the remaining bytes; length($data) is correct
%perl od -c od | head -n1
00000017   #   !   /   u   s   r   /   b   i   n   /   p   e   r   l  \n 
%od -c od | head -n1
0000000   #   !   /   u   s   r   /   b   i   n   /   p   e   r   l  \n

@mknos
od: fix line offsets
f96dd91 
* Byte offsets were broken in a previous commit
* $offset1 is advanced by -j SKIP_BYTES; otherwise it counts from zero
* Advance $offset1 only after successfully printing a line of output (this does not affect $is_limit)
* At EOF, $offset1 is advanced by the remaining bytes; length($data) is correct

%perl od -c od | head -n1
00000017   #   !   /   u   s   r   /   b   i   n   /   p   e   r   l  \n 
%od -c od | head -n1
0000000   #   !   /   u   s   r   /   b   i   n   /   p   e   r   l  \n
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: od The od program labels Dec 26, 2023
@briandfoy briandfoy self-assigned this Dec 27, 2023
@briandfoy briandfoy merged commit a8deb84 into briandfoy:master Dec 27, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 29, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: od The od program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy