fortune: fail for bad options #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Dec 29, 2023
mknos
commented
- Print usage and exit if an unknown option was entered, following OpenBSD version[1]
- -h is not really an option
- Mention -n option in usage string as done in SYNOPSIS
- Document the purpose of -d flag in usage string and pod
- https://github.com/openbsd/src/blob/master/games/fortune/fortune/fortune.c#L304
* Print usage and exit if an unknown option was entered, following OpenBSD version[1] * -h is not really an option * Mention -n option in usage string as done in SYNOPSIS * Document the purpose of -d flag in usage string and pod 1. https://github.com/openbsd/src/blob/master/games/fortune/fortune/fortune.c#L304
github-actions
bot
added
Type: enhancement
|
Wow, fortune has an enhanced debugging mode. Never knew that. |
briandfoy
approved these changes
Dec 29, 2023
briandfoy
added
Status: accepted
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.