Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use two-argument form of FileHandle->new #398

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Use two-argument form of FileHandle->new #398

merged 2 commits into from
Jan 3, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 3, 2024

  • Previously the calls to open() were standardised to have 3 arguments
  • Some scripts open files via FileHandle->new() instead of open()
  • The pr command already used the preferred 2-argument form; also switch ar and file commands over to this

@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ar The ar program Program: file The file program labels Jan 3, 2024
@briandfoy briandfoy self-assigned this Jan 3, 2024
briandfoy
briandfoy approved these changes Jan 3, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@briandfoy briandfoy merged commit 64e5396 into briandfoy:master Jan 3, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 3, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ar The ar program Program: file The file program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy