Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

col: incorrectly reads file argument #407

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 13, 2024

  • GNU col and OpenBSD col treat the +2 as a bad option; usage string is printed
  • This version accepts '+2' as a filename but prints strange output
  • I started reading manuals and discovered col is not supposed to accept file arguments
  • Only stdin is supposed to be read according to standards document[1]
  • The "usage" error for GNU & OpenBSD occurs because remaining arguments are found after getopt is finished
  1. https://pubs.opengroup.org/onlinepubs/7908799/xcu/col.html
%perl col +2 col # old output
Can't open +2: No such file or directory at col line 71. #!/usr/bin/perl

=begin metadata
...
		p
		 r
		  i
		   n
		    t

		      $
		       s
			p
			 a
			  c
			   e
			    s
			     ;
Can't use an undefined value as an ARRAY reference at col line 246, <> line 267.

* GNU col and OpenBSD col treat the +2 as a bad option; usage string is printed
* This version accepts '+2' as a filename but prints strange output 
* I started reading manuals and discovered col is *not* supposed to accept file arguments
* Only stdin is supposed to be read according to standards document[1]
* The "usage" error for GNU & OpenBSD occurs because remaining arguments are found after getopt is finished

1. https://pubs.opengroup.org/onlinepubs/7908799/xcu/col.html

%perl col +2 col # old output
Can't open +2: No such file or directory at col line 71.
#!/usr/bin/perl

=begin metadata
...
		p
		 r
		  i
		   n
		    t

		      $
		       s
			p
			 a
			  c
			   e
			    s
			     ;
Can't use an undefined value as an ARRAY reference at col line 246, <> line 267.
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: col The col program labels Jan 13, 2024
@briandfoy briandfoy merged commit 528789b into briandfoy:master Jan 13, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jan 25, 2024
@briandfoy briandfoy self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: col The col program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants