sort: enforce minimum value of 1 for -F and -y #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Jan 19, 2024
mknos
commented
- Basic validation
- Options -F and -y are non-standard and control allocation limits within sort
- Currently if the value of zero is given, it is ignored because of truth-test
- Negative amounts are accepted but don't make sense in the context of a limit size
* Basic validation * Options -F and -y are non-standard and control allocation limits within sort * Currently if the value of zero is given, it is ignored because of truth-test * Negative amounts are accepted but don't make sense in the context of a limit size
github-actions
bot
added
Type: enhancement
mknos
commented
Jan 19, 2024
briandfoy
requested changes
Jan 19, 2024
briandfoy
added
the
Status: changes requested
briandfoy
approved these changes
Jan 23, 2024
briandfoy
removed
the
Status: changes requested
briandfoy
added
Status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.