Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: eliminate global variable $fname #418

Merged
merged 2 commits into from
Jan 28, 2024
Merged

ed: eliminate global variable $fname #418

merged 2 commits into from
Jan 28, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 27, 2024

  • edEdit() is always called and expects a filename to be passed in $args[0]
  • Special filename '-' is the same as no filename; edEdit() expects $args[0] to be unset and will read stdin
  • Extra file arguments are not allowed; only one file can be edited at a time
  • When stdin is read, byte counts are not displayed

@mknos
ed: eliminate global variable $fname
e86166c 
* 1st argument is the filename to be passed to edEdit()
* Special filename '-' is the same as no filename; edEdit() expects unset filename and reads stdin
* Extra file arguments are not allowed; only one file can be edited at a time
* When stdin is read, byte counts are not displayed
@mknos
previous commit incorrectly allowed "-" followed by a filename
cea304d
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 27, 2024
@briandfoy briandfoy merged commit 036ea06 into briandfoy:master Jan 28, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Jan 28, 2024
briandfoy
briandfoy reviewed Jan 28, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Why are there no options on this dialog? Oh, that's why. Already approved.

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 29, 2024
@briandfoy
Copy link
Owner

changes: internal improvements

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy