Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: document -v #421

Merged
merged 1 commit into from
Jan 28, 2024
Merged

rm: document -v #421

merged 1 commit into from
Jan 28, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 28, 2024

  • Add pod description for -v flag and include it in usage string
  • Currently nothing calls usage(), but this is still helpful for reading pod2text

@mknos
rm: document -v
678ebc5 
* Add pod description for -v flag and include it in usage string 
* Currently nothing calls usage(), but this is still helpful for reading pod2text
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: rm The rm program labels Jan 28, 2024
briandfoy
briandfoy approved these changes Jan 28, 2024
View reviewed changes
bin/rm
@@ -283,7 +283,7 @@ sub usage {
sub error_fh { my $self = shift; $self->{error_fh} }
sub error {
my $self = shift;
print { $self->error_fh || * STDERR } @_;
print { $self->error_fh || *STDERR } @_;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but I'd move that default value into error_fh.

@briandfoy briandfoy self-assigned this Jan 28, 2024
@briandfoy briandfoy merged commit efd40be into briandfoy:master Jan 28, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 28, 2024
@briandfoy
Copy link
Owner

changes: document the -v switch

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: rm The rm program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy