Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: simplify debug #432

Merged
merged 1 commit into from
Jan 31, 2024
Merged

ed: simplify debug #432

merged 1 commit into from
Jan 31, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 31, 2024 •
edited
Loading

  • Simplify -d option to become a flag and not take an argument
  • The only supported argument was "parse", so this patch makes debugging easier to enable
  • The old way with -ddebugstring did not provide any feedback if I typed an unsupported string
  • Sync usage string in Usage() and Synopsis
  • Remove redundant comment where usage string was also being maintained (but wasn't up to date with -s or -p)

@mknos
ed: simplify debug
a71fbbf 
* Simplify -d option to become a flag an not take an argument
* The only supported argument was "parse", so this patch makes debugging easier to enable
* The old way with -ddebugstring did not provide any feedback if I typed an unsupported string
* Sync usage string in Usage() and Synopsis
* Remove redundant comment where usage string was also being maintained (but wasn't up to date with -s or -p)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 31, 2024
@briandfoy briandfoy merged commit 19dcfe2 into briandfoy:master Jan 31, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Jan 31, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 31, 2024
@briandfoy
Copy link
Owner

briandfoy commented Mar 3, 2024 •
edited
Loading

changes: simplify the debug facility

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
@ronsavage
Copy link

Hi brian

Should the last commit read '... simplify ...'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @briandfoy @ronsavage