Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed: clean some redundant code #437

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 2, 2024

  • In edMove(), special code isn't needed for $count of one because the .. operator can handle 1..1
  • edPrint() already relies on this because it loops with "$adrs[0] .. $adrs[1]", where both can be equal
  • Tested with command "1m20" to move the 1st line in buffer ($end is inferred from $start)
  • Remove chmod() comment in edWrite(); OpenBSD version does not perform chmod() and that is a better reference
  • Standards document mentions nothing about changing file modes/permissions[1]
  • In edHelp() the saved error will be printed each time the "H" command enables the help flag; avoid extra return statement
  1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/ed.html

* In edMove(), special code isn't needed for $count of one because the .. operator can handle 1..1
* edPrint() already relies on this because it loops with "$adrs[0] .. $adrs[1]", where both can be equal
* Tested with command "1m20" to move the 1st line in buffer ($end is inferred from $start)
* Remove chmod() comment in edWrite(); OpenBSD version does not perform chmod() and that is a better reference
* Standards document mentions nothing about changing file modes/permissions[1]
* In edHelp() the saved error will be printed each time the "H" command enables the help flag; avoid extra return statement

1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/ed.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Feb 2, 2024
@briandfoy briandfoy merged commit 7ed0b25 into briandfoy:master Feb 2, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Feb 2, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 2, 2024
@briandfoy
Copy link
Owner

changes: clean up some internals

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants