Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmp: check length off-by-one #450

Merged
merged 1 commit into from
Feb 11, 2024
Merged

cmp: check length off-by-one #450

merged 1 commit into from
Feb 11, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 10, 2024

  • $checklength is the maximum offset in buffer to check which byte(s) in the 2 buffers are not equal
  • The subsequent loop is from 0 to $checklength, so avoid potentially accessing $bytes1[$chunk_size]
  • If $read_in1 and $read_in2 are equal to $chunk_size, the value of $checklength is not decremented
  • Calculate minimum of $read_in1 and $read_in2 (these will never exceed $chunk_size), then decrement by 1

@mknos
cmp: check length off-by-one
f76ab0b 
* $checklength is the maximum offset in buffer to check which byte(s) in the 2 buffers are not equal
* The subsequent loop is from 0 to $checklength, so avoid potentially accessing $bytes1[$chunk_size]
* If $read_in1 and $read_in2 are equal to $chunk_size, the value of $checklength is not decremented
* Calculate minimum of $read_in1 and $read_in2 (these will never exceed $chunk_size), then decrement by 1
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cmp The cop program labels Feb 10, 2024
@briandfoy briandfoy merged commit cba333a into briandfoy:master Feb 11, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Feb 11, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 11, 2024
@briandfoy
Copy link
Owner

changes: fix off-by-one error

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cmp The cop program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy