Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill: signal number validation #454

Merged
merged 1 commit into from
Feb 12, 2024
Merged

kill: signal number validation #454

merged 1 commit into from
Feb 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 12, 2024

  • The existing validation for signal-number-too-big doesn't work correctly when "use integer" is enabled
  • I tested this with a very large number
  • "perl kill -7685876587234234 12" proceeded to kill process 12 incorrectly
  • Removing integer pragma fixes this issue for me

@mknos
kill: signal number validation
8d07335 
* The existing validation for signal-number-too-big doesn't work correctly when "use integer" is enabled
* I tested this with a very large number
* "perl kill -7685876587234234 12" proceeded to kill process 12 incorrectly
* Removing integer pragma fixes this issue for me
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: kill The kill program labels Feb 12, 2024
@briandfoy briandfoy merged commit 8a055a3 into briandfoy:master Feb 12, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Feb 12, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 12, 2024
@briandfoy
Copy link
Owner

changes: validate signal number arguments

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: kill The kill program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy