Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff: reduce code noise #458

Merged
merged 1 commit into from
Feb 13, 2024
Merged

diff: reduce code noise #458

merged 1 commit into from
Feb 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 13, 2024

  • Mapping loop is more direct to write with map()
  • Check for error instead of success in output_diff()
  • Tested this with -e, -f and -u flags on some small files

@mknos
diff: reduce code noise
9c492ee 
* Mapping loop is more direct to write with map()
* Check for error instead of success in output_diff()
* Tested this with -e, -f and -u flags on some small files
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: diff The diff program labels Feb 13, 2024
@briandfoy briandfoy merged commit 2dab6c4 into briandfoy:master Feb 13, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 13, 2024
@briandfoy briandfoy self-assigned this Feb 14, 2024
@briandfoy
Copy link
Owner

changes: reduce internal clutter

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: diff The diff program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy