Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: edInsert() mostly duplicate code #466

Merged
merged 1 commit into from
Feb 29, 2024
Merged

ed: edInsert() mostly duplicate code #466

merged 1 commit into from
Feb 29, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 20, 2024

  • edInsert() handles Append "a" command and Insert "i" command
  • The special case for address 0 can be removed; the code with tmp_lines2 is general enough to handle this, i.e. for address 0, tmp_lines will be added at start of buffer and tmp_lines2 will be empty
  • In insert mode the target address is the addressed line; decrement is needed for conversion to correct array index
  • test1: "0a", "0i" and "1i" --> add input to start of buffer
  • test2: "1a" and "2i" --> add input after buffer line 1, and at buffer line 2 (equivalent)

@mknos
ed: edInsert() mostly duplicate code
f2904bd 
* edInsert() handles Append "a" command and Insert "i" command
* The special case for address 0 can be removed; the code with tmp_lines2 is general enough to handle this, i.e. for address 0, tmp_lines will be added at start of buffer and tmp_lines2 will be empty
* In insert mode the target address is the addressed line; decrement is needed for conversion to correct array index
* test1: "0a", "0i" and "1i" --> add input to start of buffer
* test2: "1a" and "2i" --> add input after buffer line 1, and at buffer line 2 (equivalent)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Feb 20, 2024
@briandfoy briandfoy merged commit 1d74b03 into briandfoy:master Feb 29, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 29, 2024
@briandfoy briandfoy self-assigned this Feb 29, 2024
@briandfoy
Copy link
Owner

changes: refactor some of the insertion code

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy