ed: failed search regression #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Jun 11, 2024
mknos
commented
- When searching with ?pattern or /pattern in a file not containing the pattern, ed incorrectly printed two '?' prompts and did not capture the expected 'no match' error
- The code after edParse() returns is not supposed to do anything in this case since edParse() already does the 'no match' error (seen when repeating the search with H mode enabled)
- Reintroduce old behaviour by adding a nop action in cmdtab (now edParse() can signal for no subsequent work to be done without a 'bad command' error being raised)
- While here, reduce code by folding edSetCurrentLine() into cmdtab
- edSetCurrentLine() is the default action if a search matches
- The structure of performing a search within CalculateLine() is confusing; this could be improved later
* When searching with ?pattern or /pattern in a file not containing the pattern, ed incorrectly printed two '?' prompts and did not capture the expected 'no match' error * The code after edParse() returns is not supposed to do anything in this case since edParse() already does the 'no match' error (seen when repeating the search with H mode enabled) * Reintroduce old behaviour by adding a nop action in cmdtab (now edParse() can signal for no subsequent work to be done without a 'bad command' error being raised) * While here, reduce code by folding edSetCurrentLine() into cmdtab * edSetCurrentLine() is the default action if a search matches * The structure of performing a search within CalculateLine() is confusing; this could be improved later
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Jun 11, 2024
briandfoy
added
Status: accepted
|
changes: fix a regression with searches that produce no matches |
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.