Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed: failed search regression #647

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Commits on Jun 11, 2024

  1. ed: failed search regression

    * When searching with ?pattern or /pattern in a file not containing the pattern, ed incorrectly printed two '?' prompts and did not capture the expected 'no match' error
    * The code after edParse() returns is not supposed to do anything in this case since edParse() already does the 'no match' error (seen when repeating the search with H mode enabled)
    * Reintroduce old behaviour by adding a nop action in cmdtab (now edParse() can signal for no subsequent work to be done without a 'bad command' error being raised)
    * While here, reduce code by folding edSetCurrentLine() into cmdtab
    * edSetCurrentLine() is the default action if a search matches
    * The structure of performing a search within CalculateLine() is confusing; this could be improved later
    mknos authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7a3c127 View commit details
    Browse the repository at this point in the history