Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tail: retire -h flag #654

Merged
merged 1 commit into from
Jun 15, 2024
Merged

tail: retire -h flag #654

merged 1 commit into from
Jun 15, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 15, 2024

  • The standard tail command doesn't support -h [1]
  • GNU and OpenBSD versions print "unknown option" error
  • With this patch, usage string is printed after the error, which matches OpenBSD version
  • Simplify usage() so it only takes a single (optional) error message param
  1. https://pubs.opengroup.org/onlinepubs/007908799/xcu/tail.html

@mknos
tail: retire -h flag
600091e 
* The standard tail command doesn't support -h [1]
* GNU and OpenBSD versions print "unknown option" error
* With this patch, usage string is printed after the error, which matches OpenBSD version
* Simplify usage() so it only takes a single (optional) error message param

1. https://pubs.opengroup.org/onlinepubs/007908799/xcu/tail.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tail The tail program labels Jun 15, 2024
@briandfoy briandfoy merged commit af39cd4 into briandfoy:master Jun 15, 2024
2 checks passed
@briandfoy
Copy link
Owner

changes: remove the -h option to be consistent with GNU / BSD

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jun 15, 2024
@briandfoy briandfoy self-assigned this Jun 15, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tail The tail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy