Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: line 0 is invalid for write command #658

Merged
merged 1 commit into from
Jun 25, 2024
Merged

ed: line 0 is invalid for write command #658

merged 1 commit into from
Jun 25, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 18, 2024

  • When testing previous commit I discovered that this version of ed incorrectly accepts "0,1w file.mp3" command
  • Address range 0-1 is not valid because lines count from 1
  • Error was also not raised for "0w file.mp3", i.e. single-address mode
  • Follow OpenBSD and GNU versions by printing invalid-address error
  • Technically, the command ",1w file" is valid; this is interpreted as implied range of "1,1" which is the same as just "1w"

@mknos
ed: line 0 is invalid for write command
f858b12 
* When testing previous commit I discovered this version of ed incorrectly accepts "0,1w file.mp3" command
* Address range 0-1 is not valid because lines count from 1
* Error was also not raised for "0w file.mp3", i.e. single-address mode
* Follow OpenBSD and GNU versions by printing invalid-address error
* Technically, ",1w file" command is valid because this is interpreted as implied range of "1,1" which is the same as just "1w"
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jun 18, 2024
@briandfoy
Copy link
Owner

changes: line 0 is no longer valid for write command

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jun 25, 2024
@briandfoy briandfoy self-assigned this Jun 25, 2024
@briandfoy briandfoy merged commit 7836a41 into briandfoy:master Jun 25, 2024
2 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy