ed: command mode versus ctrl+d #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Jun 26, 2024
mknos
commented
- Fix the error 'Can't "last" outside a loop block at ed line 189', triggered by ctrl+d (eof) after loading a file in ed
- When adding the input() function the "last" statement was missed in the error handling code
- Consistently clear globals before calling edParse(); prevent saved state from previous command input from being used by subsequent commands
- Follow OpenBSD ed and make ^D equivalent to typing the regular "q" command
- Example case: Open a text file and delete 1st line with "1d" command, then hit ^D
- The first time I hit ^D in command mode, edQuit() will print a warning about the modified buffer (called via edQuitAsk())
- When I hit ^D a second time, edQuit() remembers that a warning was already printed, so the program exits
* Fix the error 'Can't "last" outside a loop block at ed line 189', triggered by ctrl+d (eof) after loading a file in ed * When adding the input() function the "last" statement was missed in the error handling code * Consistently clear globals before calling edParse(); prevent saved state from previous command input from being used by subsequent commands * Follow OpenBSD ed and make ^D equivalent to typing the regular "q" command * Example case: Open a text file and delete 1st line with "1d" command, then hit ^D * The first time I hit ^D in command mode, edQuit() will print a warning about the modified buffer (called via edQuitAsk()) * When I hit ^D a second time, edQuit() remembers that a warning was already printed, so the program exits
github-actions
bot
added
Type: enhancement
briandfoy
approved these changes
Jun 26, 2024
|
changes: treat Control-D as the q command so ed exits gracefully |
briandfoy
added
Type: bug
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.