Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

du: traverse() tweak #667

Merged
merged 1 commit into from
Jul 16, 2024
Merged

du: traverse() tweak #667

merged 1 commit into from
Jul 16, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 16, 2024

  • Recursive call to traverse() is slightly easier to see when it's not surrounded by "unless"
  • Move bypass for . and .. directory entries to top of loop because the result of catfile() would be ignored
  • Also switch to "my" to declare handle for opendir(); this makes perlcritic happy

@mknos
du: traverse() tweak
12258ec 
* Recursive call to traverse() is slightly easier to see when it's not surrounded by "unless"
* Move bypass for . and .. directory entries to top of loop because the result of catfile() would be ignored
* Also switch to "my" to declare handle for opendir(); this makes perlcritic happy
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: du The du program labels Jul 16, 2024
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:48 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 16, 2024 10:49 — with GitHub Actions Inactive
@briandfoy briandfoy merged commit 5574449 into briandfoy:master Jul 16, 2024
23 checks passed
@briandfoy briandfoy self-assigned this Jul 16, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jul 16, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: du The du program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy