Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: retire -t extension #748

Merged
merged 1 commit into from
Sep 30, 2024
Merged

grep: retire -t extension #748

merged 1 commit into from
Sep 30, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 29, 2024 •
edited by briandfoy
Loading

  • When running in recursive mode, standard grep is not required to support sorting of directory entries by modification time [1]
  • The -t option does not exist in BSD, GNU, Solaris or Plan9 versions of grep
  • Remove -t to follow BSD version more closely (bump version since now a usage string is printed for -t)
  1. https://pubs.opengroup.org/onlinepubs/009604299/utilities/grep.html

@mknos
grep: retire -t extension
f2c550f 
* When running in recursive mode, standard grep is not required to support sorting of directory entries by modification time [1]
* The -t option does not exist in BSD, GNU, Solaris or Plan9 versions of grep
* Remove -t to follow BSD version more closely (bump version since now a usage sting is printed for -t)

1. https://pubs.opengroup.org/onlinepubs/009604299/utilities/grep.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Sep 29, 2024
@coveralls
Copy link

coveralls commented Sep 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11093701246

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11071061044: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Sep 30, 2024
@briandfoy briandfoy merged commit f19de95 into briandfoy:master Sep 30, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: remove non-standard -t switch, since ordering dirs all the way down the line is not that easy

@briandfoy briandfoy removed the Priority: low get to this whenever label Sep 30, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy