what: reduce code nesting

[mknos]

• Rewrite printWhat() function with fewer levels of nesting
• Input loop is restructured to no longer require $done variable
• Replace if-regex-matches loop with grep()
• I verified that the output, with and without -s flag, matches the output of an older commit when running command across all of /usr/bin on my Linux system
• I also ran a diff of output between -s and not-s to show that -s only lists one match per input file

%perl what /usr/bin/* > whatnew 
%perl ~/PerlPowerTools3/bin/what /usr/bin/* > whatold 
%cmp whatold whatnew 
%perl what -s /usr/bin/* > whatsnew 
%perl ~/PerlPowerTools3/bin/what -s /usr/bin/* > whatsold 
%cmp whatsnew whatsold  
%diff -U1 whatsnew whatnew 
--- whatsnew	2024-09-30 22:32:43.669989040 +0800
+++ whatnew	2024-09-30 22:31:50.659989071 +0800
@@ -282,2 +282,3 @@
 /usr/bin/crontab:
+         Copyright 1988,1989,1990,1993,1994 by Paul Vixie
          All rights reserved
@@ -300,2 +301,3 @@
 /usr/bin/cvs:
+        rcsid_bron: $miros: src/gnu/usr.bin/cvs/lib/getdate.y,v 1.14 2021/01/30 02:28:27 tg Exp $
         rcsid_code: $MirOS: src/gnu/usr.bin/cvs/lib/getdate.c,v 1.19 2021/01/30 02:30:17 tg Exp $
@@ -433,2 +435,3 @@
          dvi2tty.c 6.0.0 20160305 M.J.E. Mol (c) 1989-2010, and contributors (c) -2016
+         dvistuff.c  6.0.0 20101027 M.J.E. Mol (c) 1989-2010
 /usr/bin/dviasm:
@@ -542,2 +545,3 @@
 /usr/bin/file:
+        $File: file.c,v 1.187 2020/06/07 17:38:30 christos Exp $
         $File: seccomp.c,v 1.15 2020/05/30 23:56:26 christos Exp $
@@ -1372,2 +1376,3 @@
 /usr/bin/pbyacc:
+        yaccpar 1.8 (Berkeley) 01/20/91 (JAKE-P5BP-0.6 04/26/98)
         yaccpar 1.8 (Berkeley) 01/20/91

[coveralls]

Pull Request Test Coverage Report for Build 11125085784

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.7%) to 73.069%

---

Totals
Change from base Build 11098690193:	-0.7%
Covered Lines:	350
Relevant Lines:	479

---

💛 - Coveralls