Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what: exit(0) only for match #754

Merged
merged 1 commit into from
Oct 4, 2024
Merged

what: exit(0) only for match #754

merged 1 commit into from
Oct 4, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 4, 2024

  • Similar to grep command, exit code 0 means at least one match occurred when looking at input files
  • Unlike grep, exit code 1 is shared between no-match and error conditions (e.g. file could not be opened) [1]
  • Continue to bail on the 1st open() failure, but now go through exit() instead of die()
  • Difference discovered when testing against OpenBSD version
  1. https://pubs.opengroup.org/onlinepubs/009696799/utilities/what.html

@mknos
what: exit(0) only for match
aeae9d1 
* Similar to grep command, exit code 0 means at least one match occurred when looking at input files
* Unlike grep, exit code 1 is shared between no-match and error conditions (e.g. file could not be opened) [1]
* Continue to bail on the 1st open() failure, but now go through exit() instead of die()
* Difference discovered when testing against OpenBSD version

1. https://pubs.opengroup.org/onlinepubs/009696799/utilities/what.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: what The what program labels Oct 4, 2024
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:36 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 4, 2024 13:37 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11180975008

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11175943999: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 4469a0e into briandfoy:master Oct 4, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: exit with 0 only if there are matches

@briandfoy briandfoy self-assigned this Oct 4, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: what The what program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy