Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: remove code-generator #756

Merged
merged 1 commit into from
Oct 7, 2024
Merged

grep: remove code-generator #756

merged 1 commit into from
Oct 7, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 5, 2024

  • Define each of the different matching modes as its own closure within parse_args()
  • All matching modes support multiple patterns
  • The code is more readable because code doesn't get passed to eval() as a string
  • The code in the closures is now able to fail at compile time, instead of deferring failure to runtime eval() call

@mknos
grep: remove code-generator
79f2cd0 
* Define each of the different matching modes as its own closure within parse_args()
* All matching modes support multiple patterns
* The code is more readable because perl code doesn't get passed to eval() as a string
* The code in the closures is now able to fail at compile time, instead of deferring failure to runtime eval() call
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Oct 5, 2024
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 5, 2024 15:02 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11194155461

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11192041877: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

briandfoy
briandfoy approved these changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh gees, what a mess. I'm sure someone had some idea about how this could be interesting, but then it never really quite needed it.

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 7, 2024
@briandfoy briandfoy self-assigned this Oct 7, 2024
@briandfoy briandfoy merged commit c0ad2c3 into briandfoy:master Oct 7, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy