Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: allow repeated -e and -f #757

Merged
merged 1 commit into from
Oct 8, 2024
Merged

grep: allow repeated -e and -f #757

merged 1 commit into from
Oct 8, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 7, 2024 •
edited
Loading

  • If -e and -f are not provided, the first argument to grep is a pattern
  • If -e or -f is provided, the first argument to grep is a file
  • Allow multiple -e and -f options to translate to multiple elements in the @patterns list
  • This patch follows how GNU and BSD versions behave
  • Bump version
  • test1: "perl grep -e include -e return a.c" --> 2 patterns, one file argument
  • test2: "echo include > P1 && echo return > P2 && perl grep -f P1 -f P2 a.c" --> 2 pattern files with one pattern each; one file argument
  • test3: "grep return a.c" --> one (default) pattern argument,one file argument

@mknos
grep: allow repeated -e and -f
7208d5a 
* If -e and -f are not provided, the first argument to grep is a pattern
* If -e or -f is provided, the first argument to grep is a file
* Allow multiple -e and -f options to translate to multiple elements in the patterns-list
* This patch follows how GNU and BSD versions behave
* Bump version
* test1: "perl grep -e include -e return a.c" --> 2 patterns, one file argument
* test2: "echo include > P1 && echo return > P2 && perl grep -f P1 -f P2 a.c" --> 2 pattern files with one pattern each; one file argument
* test3: "grep return a.c" --> one (default) pattern argument,one file argument
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Oct 7, 2024
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 7, 2024 13:30 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11216612556

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11213821123: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy
Copy link
Owner

changes: allow multiple -e or -f on the command line

@briandfoy briandfoy merged commit b6e4ec7 into briandfoy:master Oct 8, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Oct 8, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Oct 8, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy