Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsort: pairs can split across lines #759

Merged
merged 1 commit into from
Oct 15, 2024
Merged

tsort: pairs can split across lines #759

merged 1 commit into from
Oct 15, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 15, 2024

  • The previous commit handled the problem of odd input tokens being ignored, but tsort still rejects some valid input
  • Exit with failure code if close() failed, after printing output
  • Allow a single token on a line; this is valid as long as the total number of tokens is even
  • Tested against GNU version
%printf "a b\nb\n  c\n\n" > in.tsort
%tsort in.tsort # tsort (GNU coreutils) 8.32
a
b
c
%perl tsort in.tsort # with patch applied
a
b
c
%perl ~/PerlPowerTools.old/bin/tsort in.tsort # older commit gets it totally wrong
a
b

@mknos
tsort: pairs can split across lines
7044637 
* The previous commit handled the problem of odd input tokens being ignored, but tsort still rejects some valid input
* Exit with failure code if close() failed, after printing output
* Allow a single token on a line; this is valid as long as the total number of tokens is even
* Tested against GNU version

%printf "a b\nb\n  c\n\n" > in.tsort
%tsort in.tsort # tsort (GNU coreutils) 8.32
a
b
c
%perl tsort in.tsort # with patch applied
a
b
c
%perl ~/PerlPowerTools.old/bin/tsort in.tsort # from older commit 9d4efce which gets it totally wrong
a
b
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tsort The sort program labels Oct 15, 2024
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:18 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11341144965

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Files with Coverage Reduction New Missed Lines %
bin/units 3 70.77%
Totals Coverage Status
Change from base Build 11334674651: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Oct 15, 2024
@briandfoy briandfoy self-assigned this Oct 15, 2024
@briandfoy briandfoy merged commit 59942ec into briandfoy:master Oct 15, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tsort The sort program Status: accepted The fix is accepted Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy