Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: w doesn't print byte count #760

Merged
merged 1 commit into from
Oct 15, 2024
Merged

ed: w doesn't print byte count #760

merged 1 commit into from
Oct 15, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 15, 2024

  • Today I noticed that when starting ed without a file argument, writing a file with "w file.name" didn't print a byte count
  • I confirmed that BSD and GNU versions of ed do print a byte count in this case
  • When reading the code, the flag $SupressCounts should only be set when running ed in "script" mode (ed -s)
  • The code setting the flag for no file argument is not correct (w command will fail unless a filename has either been provided directly as argument, or set earlier with f command)
  • Bump version
%perl ed
a
this is ok
.
w some.file 
11
q

@mknos
ed: w doesn't print byte count
5cc3e91 
* Today I noticed that when starting ed without a file argument, writing a file with "w file.name" didn't print a byte count
* I confirmed that BSD and GNU versions of ed do print a byte count in this case
* When reading the code, the flag $SupressCounts should only be set when running ed in "script" mode (ed -s)
* The code setting the flag for no file argument is not correct (w command will fail unless a filename has either been provided directly as argument, or set earlier with f command)
* Bump version
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Oct 15, 2024
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:40 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 15, 2024 07:41 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11341483825

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Files with Coverage Reduction New Missed Lines %
bin/units 3 70.77%
Totals Coverage Status
Change from base Build 11334674651: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy added Type: bug an existing feature does not work Status: accepted The fix is accepted and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Oct 15, 2024
@briandfoy briandfoy self-assigned this Oct 15, 2024
@briandfoy briandfoy merged commit 14732c1 into briandfoy:master Oct 15, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: w commands prints byte count when ed is started without a filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: accepted The fix is accepted Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy