-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsort: allow independent nodes #761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When a node refers to itself in a pair it means the node exists but does not depend on anything * Previously, this input would result in a "cycle" error * In test file, allow node 'd' to be added to npred-hash with a predecessor count of zero, so it can appear in list-list * The inner "foreach" loop does not execute for node 'd' because it has no dependency; it has no need for an entry in succ-hash %perl cat in.tsort2 a b b c d d %perl tsort.old in.tsort2 a b c tsort.old: cycle detected %perl tsort in.tsort2 a b c d %perl cat in.tsort3 a a %perl tsort in.tsort3 a
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: tsort
The sort program
labels
Oct 16, 2024
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:45
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 16, 2024 00:46
— with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 11356756634Details
💛 - Coveralls |
briandfoy
approved these changes
Oct 16, 2024
changes: allow nodes to refer to themselves (has no dependency). This previously created a cycle error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: low
get to this whenever
Program: tsort
The sort program
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%npred
with predecessor count of zero, so it then appears in list@list
%succ