Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: simplify escape_line() #763

Merged
merged 1 commit into from
Oct 16, 2024
Merged

ed: simplify escape_line() #763

merged 1 commit into from
Oct 16, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 16, 2024

  • Pre-compute all binary escape values in a handy mapping table to avoid branching in escape_line()
  • I confirmed that the "l" command produces the same output as for the previous commit

@mknos
ed: simplify escape_line()
b30fe36 
* Pre-compute all binary escape values in a handy mapping table to avoid branching in escape_line()
* I confirmed that the "l" command produces the same output as for the previous commit
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Oct 16, 2024
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 16, 2024 14:32 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11367864439

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11366379697: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit fcaf065 into briandfoy:master Oct 16, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Oct 16, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Oct 16, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy