Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: -f option doesn't work properly #769

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 24, 2024

  • Non-standard option -f takes a path argument to read a list of paths to check
  • Problem1: "file -f 0" is valid but incorrect truth check did not recognise -f
  • Problem2: lines read from file are terminated by newlines, and these newlines were incorrectly being added into ARGV as part of the string (resulting in open() failure)
%cat 0
comm
ar
%perl file -f 0
comm: executable /usr/bin/perl script text
ar: executable /usr/bin/perl script text

* Option -f takes a path argument to read a list of paths to check
* Problem1: "file -f 0" is valid but incorrect truth check did not recognise -f
* Problem2: lines read from file are terminated by newlines, and these newlines were incorrectly being added into ARGV as part of the string (resulting in open() failure)

%cat 0
comm
ar
%perl file -f 0
comm: executable /usr/bin/perl script text
ar: executable /usr/bin/perl script text
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: file The file program labels Oct 24, 2024
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:56 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 07:57 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 24, 2024

Pull Request Test Coverage Report for Build 11495019829

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%

Totals Coverage Status
Change from base Build 11491874432: -0.7%
Covered Lines: 350
Relevant Lines: 479

💛 - Coveralls

@briandfoy briandfoy merged commit 1da463e into briandfoy:master Oct 24, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 24, 2024
@briandfoy briandfoy self-assigned this Oct 24, 2024
@briandfoy
Copy link
Owner

changes: -f works properly by checking the definedness of its argument instead of truthiness, and chomps the lines it reads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: file The file program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants