Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to React #78

Merged
merged 109 commits into from
Sep 22, 2023
Merged

Port to React #78

merged 109 commits into from
Sep 22, 2023

Conversation

briangann
Copy link
Owner

@briangann briangann commented Dec 24, 2022 •
edited
Loading

  • switching to create-plugin (used migrate option)
  • full port to react
  • added feature - set needle width (was a fixed value)

Fixes #79
Fixes #74

@briangann briangann changed the title 20221224 port to react Port to React Dec 24, 2022
@briangann briangann self-assigned this Dec 24, 2022
@stale
Copy link

stale bot commented Feb 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale marked stale due to inactivity label Feb 23, 2023
@briangann briangann added pinned keep open until resolved and removed stale marked stale due to inactivity labels Feb 25, 2023
@briangann briangann added the nostalebot exempt from stale bot label Mar 27, 2023
codeclimate[bot]
codeclimate bot reviewed Mar 28, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 16880 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Jun 24, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 16880 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 14, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 34750 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 14, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 34750 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 14, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 34747 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 14, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 34771 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 14, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 34771 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Sep 14, 2023

Code Climate has analyzed commit caa2454 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 4
Style 3

View more on Code Climate.

@briangann briangann marked this pull request as ready for review September 22, 2023 03:03
@briangann briangann merged commit a675a1b into main Sep 22, 2023
2 checks passed
@briangann briangann deleted the 20221224_port_to_react branch September 22, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees

@briangann briangann

Labels
enhancement nostalebot exempt from stale bot pinned keep open until resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular is deprecated - please migrate to React Convert to React
1 participant
@briangann