Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U_BUFFER_OVERFLOW_ERROR and U_STRING_NOT_TERMINATED_WARNING need to be handled the same way instead of raising an error #111

Open
koljaa opened this issue Nov 4, 2016 · 0 comments · May be fixed by #114

Comments

@koljaa
Copy link

koljaa commented Nov 4, 2016

http://userguide.icu-project.org/strings
Regarding the following statement in the release notes the U_STRING_NOT_TERMINATED_WARNING error need to be handle the same way as U_BUFFER_OVERFLOW_ERROR.
https://github.com/brianmario/charlock_holmes/blob/master/ext/charlock_holmes/converter.c#L29

"Some functions used to set an overflow error code even when only the terminating NUL did not fit into the output buffer. These functions now set UErrorCode to U_STRING_NOT_TERMINATED_WARNING rather than to U_BUFFER_OVERFLOW_ERROR."

Or is there any reason why the U_STRING_NOT_TERMINATED_WARNING should raise an error?

@bluegod bluegod linked a pull request Apr 20, 2017 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant