Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on ruby 3.3 related to bigdecimal #1339

Closed
wants to merge 0 commits into from
Closed

Fix warning on ruby 3.3 related to bigdecimal #1339

wants to merge 0 commits into from

Conversation

VitaliySerov
Copy link
Contributor

This will fix this warning for ruby-3.3 projects that require mysql2:

/opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/gems/3.3.0/gems/mysql2-0.5.5/lib/mysql2.rb:2: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of mysql2-0.5.5 to add bigdecimal into its gemspec.

@sodabrew
Copy link
Collaborator

sodabrew commented Jan 2, 2024

Hmm, this is probably the right simple thing to do. Big decimal isn't necessarily required by all schemas, so I could imagine a user wanting to disable it.

Did Ruby proper add new native support for large decimals?

@sodabrew
Copy link
Collaborator

sodabrew commented Jan 2, 2024

Oh, could you add an explicit Ruby 3.3 to the CI matrix while you're here? It would confirm this works.

@VitaliySerov
Copy link
Contributor Author

@sodabrew Yeah ok, I will create a separate PR for 3.3 first

But seems here we got some troubles with version resolving, need to investigate and understand why simple change broke full CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants