From baae5fcb1cb508b7b7717b35a6c6f313be8d8ed2 Mon Sep 17 00:00:00 2001 From: Artyom Pavlov Date: Wed, 19 Jun 2024 19:08:49 +0300 Subject: [PATCH] Completely disable Web tests on Windows (#486) `continue-on-error` does not work as I was expecting. AFAIK GitHub Action does not have a straightforward solution for optionally failing jobs, see: https://github.com/actions/runner/issues/2347 Closes #400 --- .github/workflows/tests.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 26f0760c..4cfa41de 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -225,13 +225,12 @@ jobs: include: - os: ubuntu-22.04 host: x86_64-unknown-linux-musl - - os: windows-2022 - host: x86_64-pc-windows-msvc - # We get spurious failures on Windows, see: - # https://github.com/rust-random/getrandom/issues/400 - continue-on-error: true - os: macos-12 host: x86_64-apple-darwin + # We get spurious failures on Windows, see: + # https://github.com/rust-random/getrandom/issues/400 + # - os: windows-2022 + # host: x86_64-pc-windows-msvc runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v4