Skip to content

Commit

Permalink
generate - moved fixed width to generate file
Browse files Browse the repository at this point in the history
  • Loading branch information
@brianvoe
brianvoe committed Nov 20, 2023
1 parent e3cd440 commit f548b6c
Show file tree
Hide file tree
Showing 5 changed files with 353 additions and 369 deletions.
169 changes: 0 additions & 169 deletions fixed_width.go
View file

This file was deleted.

199 changes: 0 additions & 199 deletions fixed_width_test.go
View file

This file was deleted.

Loading

3 comments on commit f548b6c

@Mrpye
Copy link
Contributor

@Mrpye Mrpye commented on f548b6c Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I misunderstood what you were asking for when you said "When I am ready", to be honest, it's probably a good thing that you jumped in to finish it, as I did not have much free time.

Had a look through the code, and my only comment is I still think the user should be able to specify column width, only because from experience when dealing with formats like this, the receiving systems are fussy about the exact column widths.
Also having the ability to left or right-align columns is useful, thinking about it thought , it's usually numeric columns that are right-aligned so this could be a simple flag Right alignNumericFields
Just my thought, I know you want to keep it simple, but I think those couple of tweaks will make it useful without overcomplicating it.

apart from that, it's looks good.

Thanks for jumping in and tweaking.

@brianvoe
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably agree with you. My initial part was i just wanted to get your original idea in and because its just additional optional options we can add both Spacing and Alignment in a separate pr. I just had difficulty wrapping my head around things and just needed the base simplified and then we can build upon it.

Let me get through the template part as well and then we can recap

@Mrpye
Copy link
Contributor

@Mrpye Mrpye commented on f548b6c Nov 20, 2023 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.