Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ISBN 10 and ISBN13 #367

Open
phoenisx opened this issue Nov 10, 2024 · 1 comment · May be fixed by #368
Open

Support ISBN 10 and ISBN13 #367

phoenisx opened this issue Nov 10, 2024 · 1 comment · May be fixed by #368

Comments

@phoenisx
Copy link

Is it possible to support something similar to faker-js/faker#2196?
Ref: https://fakerjs.dev/api/commerce#isbn

I am learning Go, and would be happy to contribute if we agree.
Let me know if this needs to be part of a Book instance or if we need to create a separate Commerce struct to manage this resource?

@brianvoe
Copy link
Owner

Yes go for it! I would have no problem adding ISBN. Plus it will be added to gofakeit.com

Since your new Ill give you a little checklist for pr's

  1. Function - Add it in the right file
  2. 3 functions - Global, Struct and private
  3. Lookup - each file at the end has a lookup so it can be used in other places
  4. Tests - each file also has a corresponding tests file. make sure to add your stuff there too

Thanks again and good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants