Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix miss makezero bug #358

Closed
wants to merge 1 commit into from

Conversation

alingse
Copy link

@alingse alingse commented May 26, 2024

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9242669752/job/25425781695

====================================================================================================
append to slice `keyOrder` with non-zero initialized length at https://github.com/brianvoe/gofakeit/blob/master/xml.go#L16[9](https://github.com/alingse/go-linter-runner/actions/runs/9242669752/job/25425781695#step:4:10):14
====================================================================================================

Signed-off-by: alingse <alingse@foxmail.com>
@brianvoe
Copy link
Owner

This is already fixed in an upcoming pr but thank your for your submission.

@brianvoe brianvoe closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants