Novemberbranch #125
Novemberbranch #125
Conversation
…he castor_proof_files current csvs
|
The version of the script try_replace_colnames_scorecsvs.R pushed up does not accomplish it's mission. I suspect you pushed an early version. The script needs to go all the way through until you save a csv file or files which are the one you want. Further you need to specify the file by name in case you meant another one. And I added myself as a reviewer, every PR needs a revewer. |
…view. If you think all is good, I can upload the resulting score files to castor.
There was a problem hiding this comment.
@drcandacemakedamoore
This is the new file. I wanted to create a pul request like last time, but the yellow status line with a green button didn't show up, so I'm trying to get your attention this way!
There was a problem hiding this comment.
I'm not sure you meant to push this.
|
You pushed changes on the .gitignore plus 6 new files here. I do not know if you meant me to review all 6 files. If not please open a PR with one single file, and perhaps the .gitignore changes you intend. |
There was a problem hiding this comment.
This is an important script, and should be in the repo.
There was a problem hiding this comment.
Again, an important script that should be in the repo somewhere probably, but I'm not sure you meant to include it.
There was a problem hiding this comment.
Also, you are trying to merge into main. This is incorrect @AidaasinAyda . Please make a pull request into develop with only the files you want for certain.
There was a problem hiding this comment.
The pull request is onto main. Again...pull requests need to come off of develop, and go onto develop. I checked git log --branch, and this branch came from the main. Please make a PR from a branch off of develop, with only the files you want, then request to merge onto develop. Alternatively you can simply send me the files you want changed by email.
|
replaced by properly branched |
Hi makeda, could you check the score file? And if possible upload the csvss