Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new functionality #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Aug 15, 2022

  1. - conditional resources creation based enable_log_to_s3 and `enable…

    …_log_to_cloudwatch`
    
    - hardening iam - writing to our log groups only
    - all data resources moved into data.tf
    - adding missing description for outputs and roles
    - regenerated README
    - simplified `ssm_role` IAM role
    - general cleanup and consolidation
    - unified IAM polices -> terraform format
    - fixed access logs being written to the session bucket instead of access log bucket
      (target_bucket = aws_s3_bucket.access_logs_bucket[0].id)
      bridgecrewio#15
    - unify naming - `access_log_bucket_name` -> `access_logs_bucket_name` (`access_log_bucket` was not in use anyway )
    chrismazanec committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    35d4d1c View commit details
    Browse the repository at this point in the history
  2. - bugfix; `var.linux_shell_profile == "" ? var.linux_shell_profile : …

    …""` -> always return empty string
    
    - simplification of `session_manager_prefs` `aws_ssm_document` - use bool values directly
    - added new variables/module options to better cover SSM preferences : `bucket_key_prefix`, `idle_session_timeout`, `max_session_duration`, `run_as_default_user`, `enable_run_as`
    - added new outputs: `iam_policy_arn`, `document_name`, `document_arn`
    - regenerated `README.md`
    chrismazanec committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    aee5e26 View commit details
    Browse the repository at this point in the history