Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous responsive wrapper is not disposed when player is recreated #66

Open
bc-paul opened this issue Dec 26, 2019 · 1 comment
Open

Comments

@bc-paul
Copy link
Contributor

bc-paul commented Dec 26, 2019

Steps to reproduce:

  • Set the ReactPlayerLoader to responsive:
    embedOptions={{ responsive: true }}
  • Update the component with new account ID / video ID props to force the player to be recreated

Results: The previous responsive wrapper is not disposed.

Example

  • Set the player loader
  • Wait 5 seconds for the new props to be set

One possible solution is to instead use options={{ fluid: true }}

@gaberogan
Copy link

I'm getting this when changing the muted and autoplay settings. This completely breaks the UI whenever a prop changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants