Thoughts about additional sensors

[GlennGoddard]

EDIT These two are Complete

I guess I never noticed that we don't get nomenclature for rain rate such as Light, Very Light, Moderate, Heavy (as seen in the WF App); this is different then the Precipitation Type.
https://community.weatherflow.com/t/rain-intensity-values/806

VERY LIGHT: < 0.25 mm/hour
LIGHT: ≥ 0.25, < 1.0 mm/hour
MODERATE: ≥ 1.0, < 4.0 mm/hour
HEAVY: ≥ 4.0, < 16.0 mm/hour
VERY HEAVY: ≥ 16.0, < 50 mm/hour
EXTREME: > 50.0 mm/hour

I've been looking into Absolute Humidity for humidity levels independent of temperature (I have been using DewPoint as this indicator but I think Absolute Humidity would handle this better)
Would need Vapor Pressure to calculate Absolute Humidity but does not need to be exposed (similar to how we have WBGT which requires black bulb temp which is calculated and not exposed to the user)

Thoughts on these two sensors?

[briis]

The first one, makes sense, and I can make that before the next release. That one will also require updates to the language files.
Absolute Humidity - Honestly, never heard about it. What would be the benefit of that sensor?

[GlennGoddard]

Absolute Humidity is the actual amount of water in volume of air.
Relative Humidity is the ratio of the amount of water in the air to the capacity of that air to hold water at the current temperature.
For the same amount of actual water in the air the relative humidity will go up when temperature goes down.
Absolute Humidity is a good indication of the actual humidity conditions independent of temperature.
Dewpoint can be used in a similar way as in the lower the dewpoint the higher the amount of water in air.

[briis]

OK, got it. I have no issues with adding that sensor to the system, if you can make the math/function.

The latest dev build, not includes the other Rain Intensity sensor. I made the text Capital Letters only, as in the App, but what is your view on that?

[GlennGoddard]

I can see arguments for both CAPITAL and lowercase. I personally like Title Case, but I won't loose sleep over any of the choices.
I personally think ALL CAPS when it is not a message that requires attention draws attention away from items that deserve more attention.

[briis]

I buy your argument. I will make the text Title Case.

[GlennGoddard]

If you bought it, I should have put a higher price tag on it.

[briis]

Uploaded a new dev build, with text in Title Case

[GlennGoddard]

I'm working today, so it will be a few hours before I can update to the latest build.

[GlennGoddard]

I can see in my Home Assistance instance that Rain Intensity is Title Case but when I look in Helpers and Translations it is CAPITALIZED.
Am I missing something or did you update only the code that went into the Docker Dev build?
I looked to see if you used title() method.

[briis]

They are there now. I forgot to push to Github after the update

[GlennGoddard]

Good to know that I wasn't loosing my mind and I indeed could not find what was not there.
So yesterday I had 0.6 inch/hour (15 mm/hr) of rain at one point in time, but today no rain...at all.
This (rain intensity) should work but I'll let you know as soon as I can positively report.

I'll work on the Absolute Humidity part when I get the opportunity. I've been occupied with getting weight from a load cell to HA via MQTT for my 3D printer filament. The 'only' part I have left is pulling the MQTT message into HA and then the calculations for the length of filament based on the filament type (which I already pull in via a REST sensor).

[briis]

I am in to 3D printing also, so I will be happy to hear how that project goes

[GlennGoddard]

https://community.home-assistant.io/t/prusa-mini-3d-printer-info/236240/42

I have percent and weight in grams currently. Percent seems kinda wasteful now, I didn't think about the fact that most spool reels are 1000g of filament. I subtract the weight of the spool and holder so I am only measuring the actual filament.

[GlennGoddard]

Documenting for future reference:

In the temperature range of 5-50 C this a reasonable estimation for absolute humidity.
AH is Absolute Humidity
RH is Relative Humidity (range of 0.0 to 1.0, i.e. 25% RH is 0.25)
TK is Air Temperature in Kelvin

AH = (1320.65/TK)RH(10**((7.4475*(TK-273.14))/(TK-39.44))
partially coded for python already ** is exponent

Hopefully will be able to drop a (partial) PR in a few days.

[GlennGoddard]

Instead of converting g/m^3 to lb/ft^3, I decided to leave the units in metric and not convert to imperial.
This is exactly what is currently done for Solar Radiation where units are left metric vice imperial units.

[GlennGoddard]

I have the change ready with the exception of the usual that I leave for you to do. Do you want me to submit PR now or wait until the long term stats is completed? Of course, this will add one more thing to the long term stats.

I think it would be better to wait so I can update my branch to include all your most recent changes so their is less for you to merge and look at, but if you want it now, I can do it. It is my Absolute_Humidity branch if you want to review it in all copious amounts of free time.

[briis]

Yes, just wait until I have the Long Term Stats completely figured out, then I will make that an official release, and we can start on the next. Thanks.

[GlennGoddard]

PR #86 added.
Needs @briis to fine tune (ie actually get it working) but other than not working, it is done.

Needs Absolute Humidity state_class and mqtt.

[briis]

Now added. Pushed to the dev build.

[GlennGoddard]

I have something weird going on with my logs but I get sensor data in HA including Absolute Humidity.

2021-10-12 16:57:09 ERROR (MainThread) [homeassistant.helpers.template] Error parsing value: 'dict object' has no attribute 'absolute_humidity' (value: {"dewpoint": {"max_day": 43.9, "max_day_time": "2021-10-12T22:58:00+00:00", "max_month": 54.7, "max_month_time": "2021-10-02T21:08:29+00:00", "max_all": 65.7, "max_all_time": "2021-08-15T01:27:22+00:00", "min_day": 36.0, "min_day_time": "2021-10-12T08:22:14+00:00", "min_month": 36.5, "min_month_time": "2021-10-11T13:30:37+00:00", "min_all": 36.5, "min_all_time": "2021-10-11T13:30:37+00:00"}, "relative_humidity": {"max_day": 96.66, "max_day_time": "2021-10-12T17:31:05+00:00", "max_month": 97.93, "max_month_time": "2021-10-01T16:37:00+00:00", "max_all": 100.0, "max_all_time": "2021-07-20T14:10:48+00:00", "min_day": 75.28, "min_day_time": "2021-10-12T23:45:00+00:00", "min_month": 54.78, "min_month_time": "2021-10-02T21:51:29+00:00", "min_all": 29.85, "min_all_time": "2021-08-13T23:39:51+00:00"}, "illuminance": {"max_day": 35512.0, "max_day_time": "2021-10-12T19:03:03+00:00", "max_month": 88501.0, "max_month_time": "2021-10-02T20:05:29+00:00", "max_all": 127533.0, "max_all_time": "2021-08-16T19:49:34+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "sealevel_pressure": {"max_day": 30.278, "max_day_time": "2021-10-12T07:00:01+00:00", "max_month": 30.349, "max_month_time": "2021-10-01T18:55:57+00:00", "max_all": 30.381, "max_all_time": "2021-09-20T18:11:54+00:00", "min_day": 30.026, "min_day_time": "2021-10-12T23:47:59+00:00", "min_month": 29.746, "min_month_time": "2021-10-05T14:32:16+00:00", "min_all": 29.543, "min_all_time": "2021-09-18T04:32:03+00:00"}, "rain_duration_today": {"max_day": 0.0, "max_day_time": "2021-10-12T07:00:01+00:00", "max_month": 257.0, "max_month_time": "2021-10-05T22:30:06+00:00", "max_all": 548.0, "max_all_time": "2021-09-19T06:23:32+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "rain_rate": {"max_day": 0.0, "max_day_time": "2021-10-12T07:00:01+00:00", "max_month": 2.28, "max_month_time": "2021-10-10T20:42:54+00:00", "max_all": 3.41, "max_all_time": "2021-09-27T20:58:41+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "solar_radiation": {"max_day": 296.0, "max_day_time": "2021-10-12T19:03:03+00:00", "max_month": 737.0, "max_month_time": "2021-10-02T20:05:30+00:00", "max_all": 1063.0, "max_all_time": "2021-08-16T19:49:34+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "lightning_strike_count_today": {"max_day": 0.0, "max_day_time": "2021-10-12T07:00:01+00:00", "max_month": 11.0, "max_month_time": "2021-10-10T22:36:52+00:00", "max_all": 25.0, "max_all_time": "2021-08-31T06:56:05+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "lightning_strike_energy": {"max_day": 16797055.0, "max_day_time": "2021-10-12T07:00:18+00:00", "max_month": 18874336.0, "max_month_time": "2021-10-02T06:39:45+00:00", "max_all": 18874336.0, "max_all_time": "2021-07-16T03:44:47+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "air_temperature": {"max_day": 49.1, "max_day_time": "2021-10-12T23:33:00+00:00", "max_month": 67.9, "max_month_time": "2021-10-02T22:48:27+00:00", "max_all": 93.4, "max_all_time": "2021-08-13T23:40:50+00:00", "min_day": 36.9, "min_day_time": "2021-10-12T08:10:15+00:00", "min_month": 37.4, "min_month_time": "2021-10-11T13:33:36+00:00", "min_all": 37.4, "min_all_time": "2021-10-11T13:33:36+00:00"}, "uv": {"max_day": 2.78, "max_day_time": "2021-10-12T19:03:04+00:00", "max_month": 6.42, "max_month_time": "2021-10-06T20:31:42+00:00", "max_all": 11.86, "max_all_time": "2021-08-16T19:49:34+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "wind_gust": {"max_day": 11.23, "max_day_time": "2021-10-12T22:00:01+00:00", "max_month": 34.78, "max_month_time": "2021-10-09T21:48:21+00:00", "max_all": 34.78, "max_all_time": "2021-10-09T21:48:21+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "wind_lull": {"max_day": 3.02, "max_day_time": "2021-10-12T11:52:23+00:00", "max_month": 3.62, "max_month_time": "2021-10-09T22:13:20+00:00", "max_all": 8.59, "max_all_time": "2021-09-25T22:34:35+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}, "wind_speed_avg": {"max_day": 5.12, "max_day_time": "2021-10-12T23:25:58+00:00", "max_month": 6.51, "max_month_time": "2021-10-09T21:48:21+00:00", "max_all": 13.58, "max_all_time": "2021-09-25T22:34:35+00:00", "min_day": 0.0, "min_day_time": null, "min_month": null, "min_month_time": null, "min_all": null, "min_all_time": null}}, template: {"attribution": "Powered by WeatherFlow2MQTT", "brand": "WeatherFlow", "max_day": "{{ value_json.absolute_humidity['max_day'] }}", "max_day_time": "{{ value_json.absolute_humidity['max_day_time'] }}", "max_month": "{{ value_json.absolute_humidity['max_month'] }}", "max_month_time": "{{ value_json.absolute_humidity['max_month_time'] }}", "max_all": "{{ value_json.absolute_humidity['max_all'] }}", "max_all_time": "{{ value_json.absolute_humidity['max_all_time'] }}", "min_day": "{{ value_json.absolute_humidity['min_day'] }}", "min_day_time": "{{ value_json.absolute_humidity['min_day_time'] }}", "min_month": "{{ value_json.absolute_humidity['min_month'] }}", "min_month_time": "{{ value_json.absolute_humidity['min_month_time'] }}", "min_all": "{{ value_json.absolute_humidity['min_all'] }}", "min_all_time": "{{ value_json.absolute_humidity['min_all_time'] }}"})

Too early to see any LTS for now. I see Absolute Humidity as an option but no data yet (expected since only been running an hour or so at this point in time).

I didn't think about it until I saw the standard eye icon but maybe mdi:water or mdi:water-opacity would be good choices.

[briis]

I have pushed this to the Dev Tag.

[GlennGoddard]

Is there a breakdown of what each item is anywhere?
My guess is:
Sensor Name
Friendly Name
Metric Units (these might be reversed)
Imperial Units (these might be reversed)
Device Class
State Class
?
MQTT Topic?
?
?
?

I'm not sure of the way this file is processed but can there be a commented section at the top to describe each?

[GlennGoddard]

I do remember now, that one of those is icon choice from looked at the other sections.

[briis]

It is in the code Line 178 of const.py

# Sensor ID, Sensor Name, Unit Metric, Unit Imperial, Device Class, State Class, Icon, Update Event, Extra Attributes, Show Min Values, Show Last Reset

[GlennGoddard]

I completely missed that before. I was always unsure, so I never did that section. Now I have to find a sensor to generate, just so I can do a complete addition.

[GlennGoddard]

Everything seems to be working well without an excessive amount of attributes now. I want to look at different icon options for Absolute Humidity. You could push to stable if you want, but I think there should be an icon first.

Are you opposed to having Dew Point be mdi:thermometer-lines that is what I currently use for my dewpoints? If you would like to keep them as is, I can continue using my customization.yaml. I am also leaning towards mdi:water-opacity for Absolute Humidity.

[briis]

Perfect. I will change the icons for the two sensors as per your request, and then push to dev. If still working, I can release tomorrow.

[briis]

Done. The new release should be on Docker within the next 10 min.

[GlennGoddard]

All appears good, you can push to stable.

[briis]

Thanks. I will do that tomorrow morning

[briis]

2.1.1 is pushed to Docker now.

[GlennGoddard]

@briis What are your thoughts on a last fully charged counter? This might be useful during this season to see how long the battery lasts. I was looking and noticed that the last time my unit was fully charged was October 16th. I know it is easy to open the app and look, but obviously it took me a month to figure it out. I have been looking at the battery percentage and seeing it be lower than normal. My Tempest has not even charged at all since Nov 23rd. I guess the cloud cover when you have rain that causes flooding also prevents the sun from charging, who would have thought that?

Or do you think this would be an unnecessary sensor for most? I believe it would be useful for both you and me but I don't know about everyone else.

[GlennGoddard]

Cloud base is needed for snow level, which would aid in predicting snow. This can all be transparent but it is some useful info.
I will work on adding cloud base and snow line.
What do you prefer "Cloud Base" or "Cloud Height"?

All you need to calculate an estimate for cloud height is the surface temperature and dew point temperature in degrees °C.
Here’s how to calculate a cloud base (in feet):

• Find the difference between the temperature at the surface and the dew point.
• Divide the difference between 2.5.
• Multiply the result by 1,000.
• This will then give you the height above ground level.
• Add the elevation of the station and this will give height above sea level. (in feet)

---

Simplified with all metric units:
CloudBase (in meters AMSL = {ground temperature (C) - dewpoint (C) }* 126 + station height (in meters)

AMSL or MSL (Above Mean Sea Level) altitude above sea level
AGL (Absolute Ground Level) altitude above ground level

[briis]

Hi Glenn,
I have not forgotten you. The thing is that another Guy is currently rewriting a lot of the Integration, so that it will be easier to maintain going forward. He will use some of the already existing modules like pyweatherflowudp which I wrote a long time ago to do the UDP Communication - but he is re-writing it from scratch and converted it to Async. That way we can remove all that code from this Add-On. That same module will also have all the standard conversions built-in, so we also don't need to maintain them here.

For the Weather Forecast, we will then use another module, I just rewrote, that handles the REST communication with WeatherFlow (pyweatherflowrest), so also a big chunk of that code can be removed. That means we can concentrate on the MQTT functions and other special formulas like the ones you go with.

So because of that, I have paused adding new stuff at the moment, but we will leave this open, so just put in stuff, that we then can look at how we implement, once the re-write is done.

[GlennGoddard]

SnowLine = (192 * AirTemperature) + StationElevation
where:
SnowLine is altitude above sea level where snow is possible in meters
AirTemperature is station temperature in C
StationElevation is altitude of station above sea level in meters

In this case SnowLine is also the FreezingLine (I'm ok with either term, but freezing line is probably the most accurate since snow line is the the altitude above which snow is possible)

Snow Probability is next with some comparisons...

[briis]

Could you create a separate issue for each sensor? It would make it easier to check off when they are implemented.

[GlennGoddard]

I could but I was going to do the PRs one sensor at a time and track it myself.

[GlennGoddard]

Cloud Base and Freezing Line are both prerequisites for snow predictions which in turn will be used for local current conditions.

[briis]

Sounds great. Just be aware that some of the calculations are moved out of this integration and in to the pyweatherflowudp module.
Most of what you suggest would most likely fit in to the helpers.py module, as they will use data from different physical devices, like Hub (Elevation) and Tempest (Air Temperature) as an example.

[GlennGoddard]

Added issues (Enhancements):
Cloud Base Added
Freezing Line Added
Snow Possible
Zembretti Algorithm

More to follow

[GlennGoddard]

@briis
What do you think would be useful for an output for others?
I calculate a lot of different things but I don't think it is all useful for output but is needed to further calculations, some of it could be useful thou. I am not sure what I should worry about setting up as an output. I am open to suggestions.

Info that are definite outputs:
Current Weather Condition
Zambretti Text

Info that might be useful:
Snow Possible (a false here will automatically return a 0% for Snow Probability)
Snow Probability
Zambretti Number (I like this as an output since it allows for graphing, each number relates to a Zambretti Text)

Info that probably is not useful but I have sent to HA for testing:
Solar Elevation (nice to graph thou)
Solar Zenith
Difference of calculated and actual Solar Radiation (might be useful for fine tuning from other locations)
Calculated percent cloud coverage (might be useful for fine tuning from other locations) (shown as % Sun)

True False conditions for each Condition (I could go either way):
Lightning
Rain
Hail
Pouring
Snow Possible (I have sent for testing)
Snow Probability (I have sent for testing)
Windy
Day
Cloudy
Partly Cloudy
Fog (still working on this one, might be more outputs from here)

Things I calculated (or imputed) just to get to estimated Solar Radiation (I don't think anything here is worth passing to the user except maybe elevation or zenith):
Latitude
Longitude
UTC Date & Time
Local Time
Julian Day
Beta (used for EOT equation)
Equation of Time (EOT)
Local Standard Time Meridian
Time Correction Factor
Local Solar Time
Hour Angle
Declination
Solar Elevation
Solar Zenith
Air Mass
Constant *Height (ah)
Solar Insolation (Estimated Solar Radiation - if no clouds)

I had some free time lately so I have been able to knock a lot out and test it.
Here is my Testing tab in HA:

[briis]

Hi Glenn,
Just started in a new job, so pretty busy. I will go through this in the weekend, and give you my comments.

[GlennGoddard]

@briis I have added Solar Elevation and Solar Insolation (estimated solar radiation) to helpers.py for a branch on my fork. I have not added anything else to properly call the functions. I managed to only have to add the include for 'time' (needed some things that 'datetime' doesn't provide).

https://github.com/GlennGoddard/hass-weatherflow2mqtt/blob/Solar-Insolation/weatherflow2mqtt/helpers.py

I ran these in a python script with no issue and with proper output. I just had to pass my latitude and longitude to the functions.
I decide to add these two first and then work on other functions and not flood them all at once.

I will try to finish it up this week and submit a PR. I will look around to see if I can add the docker environmental variables for Lat and Long but not sure if that will have to be done by you for the docker build or not.

Also once the Lat is added as an option I can add Zambretti. The Zambretti utilizes the high and low sea level pressures for an area, I could have that as a environmental variable that is added by the user or utilize the stored all time Hi and Low which is what I am currently doing.

Edit I also have some of the translations already done for the Zambretti but I will need someone to double check them.

[GlennGoddard]

Don't forget to update stable branch, looks like it has been awhile.

[briis]

Will do. Plan now is to get the Latitude and Longitude setup in DEV, and then you can add your functions. Once tested and working, I will build the stable version.

[briis]

I decided to do a new release (3.0.8) This contains a few minor fixes, and the addition of the Latitude and Longitude values. If you run in Supervised Mode latitude and longitude are added automatically from the Home Assistant values. If you run standalone you must add two new Environment variables LATITUDE and LONGITUDE.

In the program itself, these can then be referenced as self.latitude and self.longitude. Hope this works for you.

[GlennGoddard]

I will try to knock it out this week as long as life doesn't get in the way.

[briis]

I know the feeling. Just started in a new job, so I can only work on this weekends anyway.

[GlennGoddard]

@briis What am I missing?
I am missing where the MQTT data is sent but I don't see it in weatherflow_mqtt.py
Am I missing something because I have a function use the output on the other?
I edited my docker container with the following:
I added an import time to helpers.py

I can push a PR and have you add the MQTT

sensor_description.py:

    SensorDescription(
        id="solar_elevation",
        name="Solar Elevation",
        unit_m="°",
        unit_i="°",
        state_class=STATE_CLASS_MEASUREMENT,
        icon="angle-acute",
        event=EVENT_OBSERVATION,
        attr="solar_radiation",
        custom_fn=lambda cnv, device, latitude, logitude: None
        if None in (self.latitude, self.longitude)
        else cnv.solar_elevation(self.latitude, self.longitude)
    ),
    SensorDescription(
        id="solar_insolation",
        name="Solar Insolation",
        unit_m="W/m^2",
        unit_i="W/m^2",
        state_class=STATE_CLASS_MEASUREMENT,
        icon="solar-power",
        event=EVENT_OBSERVATION,
        attr="solar_radiation",
        custom_fn=lambda cnv, device, elevation, solar_elevation: None
        if None in (self.elevation, self.solar_elevation)
        else cnv.solar_insolation(self.elevation, self.solar_elevation)
    ),

helpers.py:

    def solar_elevation(self, latitude, longitude):
        """ Return Sun Elevation in Degrees with respect to the Horizon.
        Input:
            Latitude in Degrees and fractional degrees (no docker variable yet)
            Longitude in Degrees and fractional degrees (no docker variable yet)
            Local Time
            UTC Time
        Where:
            jd is Julian Date (Day of Year only), then Julian Date + Fractional True
            lt is Local Time (####) 24 hour time, no colon
            tz is Time Zone Offset (ie -7 from UTC)
            beta is Beta for EOT
            lstm is Local Standard Time Meridian
            eot is Equation of Time
            tc is Time Correction Factor
            lst is Local Solar Time
            h is Hour Angle
            dec is Declination
            se is Solar Elevation
            ** All Trigonometry Fuctions need Degrees converted to Radians **
            ** The assumption is made that correct local time is established **
        """
        if latitude is None or longitude is None:
            return None

        cos = math.cos
        sin = math.sin
        asin = math.asin
        radians = math.radians
        degrees = math.degrees
        jd = time.localtime(time.time()).tm_yday
        hr = time.localtime(time.time()).tm_hour
        min = time.localtime(time.time()).tm_min
        lt = hr + min/60
        tz = time.localtime(time.time()).tm_gmtoff/3600
        jd = jd + lt/24
        beta = (360/365) * (jd - 81)
        lstm = 15 * tz
        eot = (9.87*(sin(radians(beta*2)))) - (7.53*(cos(radians(beta)))) - (1.5*(sin(radians(beta))))
        tc = (4 * (longitude - lstm)) + eot
        lst = lt + tc/60
        h = 15 * (lst - 12)
        dec = cos(radians(((jd) + 10) * (360/365))) * (-23.44)
        se = degrees(asin(sin(radians(latitude)) * sin(radians(dec)) + cos(radians(latitude)) * cos(radians(dec)) * cos(radians(h))))
        se = round(se)

        return se

    def solar_insolation(self, elevation, solar_elevation):
        """ Return Estimation of Solar Radiation at current sun elevation angle.
        Input:
            Solar Elevation in Degrees
            Elevation in Meters
        Where:
            sz is Solar Zenith in Degrees
            ah is (Station Elevation Compensation) Constant ah_a = 0.14, ah_h = Station elevation in km
            am is Air Mass of atmoshere between Station and Sun
            1353 W/M^2 is considered Solar Radiation at edge of atmoshere
            ** All Trigonometry Fuctions need Degrees converted to Radians **
        """
        if solar_elevation is None or elevation is None:
            return None

        cos = math.cos
        sin = math.sin
        asin = math.asin
        radians = math.radians
        degrees = math.degrees
        se = solar_elevation
        sz = 90 - se
        ah_a = 0.14
        ah_h = elevation / 1000
        ah = ah_a * ah_h
        if se >= 0:
            am = 1/(cos(radians(sz)) + 0.50572*pow((96.07995 - sz),(-1.6364)))
            si = (1353 * ((1-ah)*pow(.7, pow(am, 0.678))+ah))*(sin(radians(se)))
        else:
            am = 1
            si = 0
        si = round(si)

        return si

[briis]

Yes do that. It will most likely not be completed before the weekend.

[GlennGoddard]

@briis
What are you thoughts on doubling the amount of sensors? Instead of displaying metric or imperial per user, we output both and append with _metric or _imperial. Then the user could select what they want in HA to use. Some places like Canada use a combination of imperial and metric; for example they use feet for length but Celsius for temperature. This would (or could) cause some breaking changes due to sensor name changes; or we triple the output and have exactly what we have as output dependent on imperial or metric AND we add all imperial and metric to existing (I don't recommend this, but would eliminate a breaking change).

Separately, the PR for Zambretti 'should' have everything except the Danish translation and the All Time Max and Min. I could not readily find a Danish translation for the Zambretti text; and I didn't want to rely on Google Translate to give me the text.
For the Zambretti Min and Max pressures, if it is not easy to access those numbers internally; then they could be Environmental Variables or I could put in a general estimate of High and Low (this would make it way less accurate however).

[briis]

My Initial thoughts are, not a good idea as is, as this will create an obscene amount of sensors that most people will never need, plus introduce a major breaking change.
However, having a way to decide what unit is returned for what type of sensor, could be a more viable option. That would be a break-out of metric/imperial to units per type of data. (Distance, Speed, Precipitation etc.)

The default values for these will still be metric or imperial, but then people could pick their choice in either the Docker Run command or in the config file for the Add-On.

This will need quite some work done in the pyweatherflowudp module, so it is not something that will happen in the near future.

I have the whole Sunday for myself, so I will look at the Zambretti Integration and hopefully get that in to the dev build. I do think I already have the Danish Translations available somewhere as I did them in the past when running another system. (Or else I will do them again)