build(deps): bump winston-transport from 4.7.1 to 4.8.0 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
CI Failure Feedback 🧐(Checks updated until commit 46c7734)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
Bumps [winston-transport](https://github.com/winstonjs/winston-transport) from 4.7.1 to 4.8.0. - [Release notes](https://github.com/winstonjs/winston-transport/releases) - [Changelog](https://github.com/winstonjs/winston-transport/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston-transport@v4.7.1...v4.8.0) --- updated-dependencies: - dependency-name: winston-transport dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot-npm_and_yarn-winston-transport-4.8.0
branch
from
f33e026 to
46c7734
Compare
|
@ramhr can you please take a look |
ramhr
reviewed
Oct 27, 2024
| const logMessage = this._buildLog(info); | ||
|
|
||
| this.sender.send(logMessage, (err) => { | ||
| this.sender.send(info[MESSAGE], (err) => { |
There was a problem hiding this comment.
The info[MESSAGE] is the formatted message as built in the format phase of the winston-transport pipeline. The info itself is still the same log object.
ramhr
reviewed
Oct 27, 2024
| @@ -185,7 +190,7 @@ class LogstashUDP extends Transport { | |||
| } | |||
|
|
|||
| _buildLog(info) { | |||
| const meta = Object.assign({}, info, this.meta_defaults); | |||
| const meta = Object.assign(info, this.meta_defaults); | |||
There was a problem hiding this comment.
winston-transport already does Object.assign({}, info) before passing it to the format, so it's already a fresh object and no need to dup it again.
ramhr
reviewed
Oct 27, 2024
| if (!this.format) { | ||
| this.format = defaultFormat; | ||
| } else { | ||
| this.format = winston.format.combine(this.format, defaultFormat); |
There was a problem hiding this comment.
Just in case someone passes a custom format in the options, merge it with the udp transport format.
ramhr
reviewed
Oct 27, 2024
|
|
||
| expect(() => { | ||
| logger.info("bad", { timer: setTimeout(() => {}, 10) }); | ||
| logger.info("bad", { circular }); |
There was a problem hiding this comment.
This gives the same affect, but is clearer to understand.
With the updated `winston-transport`, the transport write pipeline was changed, the place where the `log` method is called is different. Before, errors inside the log were always handled synchronously right after the write, but now in practice it's handled in `process.nextTick`. This still runs in the same tick of the event loop, but after the current operation is finished. As a side effect, this means that errors thrown there are not caught in the current operation's context and try/catch blocks wrapping it won't work. This means that in case of the format error which is tested in the broken unit test, no error is caught in the test so it fails. In fact, the logger does throw the error, but it's thrown only after the test finishes as an unhandled exception, which is very bas and I guess that's why this test exists. In order to fix the issue, I moved the message formatting into the `format` part of the winston-transport pipeline, instead of inside of the `log` function itself. When there is a formatting error inside this pipeline, winston catches it on it's own, handles it internally and rethrows it, so the log action would throw it and it can be caught.
ramhr
force-pushed
the
dependabot-npm_and_yarn-winston-transport-4.8.0
branch
from
8ae3e50 to
039107e
Compare
|
A newer version of winston-transport exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@dependabot recreate |
|
Superseded by #131. |
dependabot
bot
deleted the
dependabot-npm_and_yarn-winston-transport-4.8.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps winston-transport from 4.7.1 to 4.8.0.
Release notes
Sourced from winston-transport's releases.
Commits
75c5d2f4.8.0000b11fBump readable-stream from 3.6.0 to 4.5.2 (#201)7e7dbc6Bump nyc from 17.0.0 to 17.1.0 (#243)d85058cBump mocha from 10.6.0 to 10.7.3 (#233)f721b63Bump@types/nodefrom 20.14.10 to 22.6.0 (#241)ff4f65eBump eslint from 9.6.0 to 9.11.0 (#242)fb8383efix tests (#244)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)