Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Latest" shows as "dev-master" with "minimum-stability: dev" #126

Open
chillu opened this issue Mar 19, 2019 · 3 comments
Open

"Latest" shows as "dev-master" with "minimum-stability: dev" #126

chillu opened this issue Mar 19, 2019 · 3 comments

Comments

@chillu
Copy link
Contributor

chillu commented Mar 19, 2019

It's a bit pointless to show the latest dev branch as a release, right? That's not what we want people to upgrade to. This is on installer@4.2.0, not CWP. Maybe it's different in CWP due to recipe constraints?

image

@robbieaverill
Copy link
Contributor

robbieaverill commented Mar 19, 2019

The data we show in this report is essentially just a proxy for composer outdated. We haven't built in any layers of customisation yet, but we can definitely do that. If you take minimum-stability: dev out of your composer.json you might get different results (I realise that you're probably using an out-of-the-box CWP install to test this with)

@chillu chillu changed the title "Latest" shows as "dev-master" "Latest" shows as "dev-master" with "minimum-stability: dev" Mar 21, 2019
@chillu
Copy link
Contributor Author

chillu commented Mar 21, 2019

Good point. Looks like composer outdated doesn't have any switches like --stable-only (https://getcomposer.org/doc/03-cli.md#outdated). But looking at our installers, both the CWP and core one have minimum-stability: dev. So the "latest" column is effectively useless at the moment, unless projects remove that constraint. Which I believe very few people do, because it's usually not realistic. We might as well hide it until we create our own logic to determne "latest stable". This is particularly bad since it won't show people on CWP 1.x that CWP 2.x even exists, right? It'll just show dev-master everywhere, which doesn't help the decision makers which this module targets. /cc @brynwhyman

@chillu
Copy link
Contributor Author

chillu commented Mar 21, 2019

Maybe that would be an opportunity for a small patch provided back to the composer project, introducing a composer outdated --minimum-stability override?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants